Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_recovery_services_vault_resource_guard_association #21712

Merged
merged 5 commits into from
May 26, 2023
Merged

New Resource: azurerm_recovery_services_vault_resource_guard_association #21712

merged 5 commits into from
May 26, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented May 9, 2023

resolve #18403

test

❯ tftest recoveryservices TestAccSiteRecoveryVaultGuardProxy_basic
=== RUN   TestAccSiteRecoveryVaultGuardProxy_basic
=== PAUSE TestAccSiteRecoveryVaultGuardProxy_basic
=== CONT  TestAccSiteRecoveryVaultGuardProxy_basic
--- PASS: TestAccSiteRecoveryVaultGuardProxy_basic (383.73s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      383.783s

@ziyeqf ziyeqf mentioned this pull request May 9, 2023
Closed
1 task
@ziyeqf
update per comments
606440d 
Signed-off-by: ziyeqf <[email protected]>
@ziyeqf ziyeqf changed the title New Resource: azurerm_recovery_services_vault_guard_proxy New Resource: azurerm_recovery_services_vault_resource_guard_association May 18, 2023
katbyte
katbyte approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ziyeqf - LGTM once conflicts are resolved

@katbyte katbyte merged commit 28cf0b8 into hashicorp:main May 26, 2023
katbyte added a commit that referenced this pull request May 26, 2023
@katbyte
Update CHANGELOG.md #21712
4502231
@github-actions github-actions bot added this to the v3.58.0 milestone May 26, 2023
@github-actions
Copy link

This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies documentation service/recovery-services size/XL
Projects
None yet
Milestone
v3.58.0
Development

Successfully merging this pull request may close these issues.

Support for Multi-User-Authorization in Recovery Services Vault
3 participants
@ziyeqf @katbyte @catriona-m